Skip to content

chore!(stackable-webhook): Default listen address to bind to all addresses #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2025
Merged

chore!(stackable-webhook): Default listen address to bind to all addresses #1045

merged 6 commits into from
May 21, 2025

Conversation

sbernauer
Copy link
Member

Description

Needed for CRD conversions.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer self-assigned this May 21, 2025
@sbernauer sbernauer mentioned this pull request May 21, 2025
Open
81 tasks
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 21, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense for webhooks. They will generally be connected to from outside their pod.

Techassi
Techassi requested changes May 21, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two suggestions.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 21, 2025
@sbernauer sbernauer requested a review from Techassi May 21, 2025 13:12
@sbernauer sbernauer requested review from NickLarsenNZ and Techassi and removed request for Techassi May 21, 2025 13:42
@sbernauer sbernauer enabled auto-merge May 21, 2025 14:37
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 21, 2025
@sbernauer sbernauer disabled auto-merge May 21, 2025 14:38
@sbernauer sbernauer changed the title chore!(stackable-webhook): Default listen address to bind to all interfaces chore!(stackable-webhook): Default listen address to bind to all addresses May 21, 2025
@sbernauer sbernauer enabled auto-merge May 21, 2025 14:38
@sbernauer sbernauer added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 65a6de5 May 21, 2025
7 of 8 checks passed
@sbernauer sbernauer deleted the chore/bind-addr branch May 21, 2025 14:47
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @NickLarsenNZ @Techassi